Xuanwo commented on code in PR #6:
URL: https://github.com/apache/iceberg-rust/pull/6#discussion_r1271790885
##########
src/error.rs:
##########
@@ -0,0 +1,11 @@
+use thiserror::Error;
+
+#[derive(Error, Debug)]
+pub enum IcebergError {
Review Comment:
Wrapping all errors with `thiserror` is convenient for developers but not
good for users. My primary concern is how users will handle the returning
errors.
For example, does it meaningful for users to distinguish between `utf8
error`, `json format error` or `avro error`? By providing the custom error by
us, users can decide which action to take by error kind and know more context
while needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
