rustyconover commented on code in PR #8084:
URL: https://github.com/apache/iceberg/pull/8084#discussion_r1269497428
##########
python/pyiceberg/avro/reader.py:
##########
@@ -321,51 +336,84 @@ def __repr__(self) -> str:
def __hash__(self) -> int:
"""Returns a hashed representation of the StructReader class."""
- return hash(self.field_readers)
+ return self._hash
-@dataclass(frozen=True)
+@dataclass(frozen=False, init=False)
class ListReader(Reader):
- __slots__ = ("element",)
+ __slots__ = ("element", "is_int_list", "_hash")
element: Reader
+ def __init__(self, element: Reader) -> None:
+ super().__init__()
+ self.element = element
+ self._hash = hash(self.element)
+ self._is_int_list = isinstance(self.element, IntegerReader)
+
def read(self, decoder: BinaryDecoder) -> List[Any]:
- read_items = []
+ read_items: List[Any] = []
block_count = decoder.read_int()
while block_count != 0:
if block_count < 0:
block_count = -block_count
_ = decoder.read_int()
- for _ in range(block_count):
- read_items.append(self.element.read(decoder))
+ if self._is_int_list:
+ decoder.read_ints(block_count, read_items)
+ else:
+ for _ in range(block_count):
+ read_items.append(self.element.read(decoder))
block_count = decoder.read_int()
return read_items
def skip(self, decoder: BinaryDecoder) -> None:
_skip_map_array(decoder, lambda: self.element.skip(decoder))
+ def __hash__(self) -> int:
+ """Returns a hashed representation of the ListReader class."""
+ return self._hash
-@dataclass(frozen=True)
+
+@dataclass(frozen=False, init=False)
class MapReader(Reader):
- __slots__ = ("key", "value")
+ __slots__ = ("key", "value", "_is_int_int", "_is_int_bytes",
"_key_reader", "_value_reader", "_hash")
key: Reader
value: Reader
+ def __init__(self, key: Reader, value: Reader) -> None:
+ super().__init__()
+ self.key = key
+ self.value = value
+ self._is_int_int = isinstance(self.key, IntegerReader) and
isinstance(self.value, IntegerReader)
+ self._is_int_bytes = isinstance(self.key, IntegerReader) and
isinstance(self.value, BinaryReader)
+ self._key_reader = self.key.read
Review Comment:
Fixed in updated commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
