ajantha-bhat commented on code in PR #8098:
URL: https://github.com/apache/iceberg/pull/8098#discussion_r1269221590


##########
parquet/src/test/java/org/apache/iceberg/avro/TestParquetReadProjection.java:
##########
@@ -32,7 +32,7 @@ public class TestParquetReadProjection extends 
TestReadProjection {
   protected GenericData.Record writeAndRead(
       String desc, Schema writeSchema, Schema readSchema, GenericData.Record 
record)
       throws IOException {
-    File file = temp.resolve(desc + ".parquet").toFile();

Review Comment:
   That may require moving to `Junit5` for a whole `iceberg-core` module. I am 
afraid I don't have a time to work on that. 
   @coded9, if you are intersted, please feel free to work on it.  
   
   I was doing a POC of partition stats where I had to move all the files of 
iceberg-parquet into iceberg-core, that time I found this duplicate code. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to