nastra commented on code in PR #8094:
URL: https://github.com/apache/iceberg/pull/8094#discussion_r1267738951
##########
docs/spark-ddl.md:
##########
@@ -306,12 +306,17 @@ ALTER TABLE prod.db.sample ALTER COLUMN col FIRST
ALTER TABLE prod.db.sample ALTER COLUMN nested.col AFTER other_col
```
-Nullability can be changed using `SET NOT NULL` and `DROP NOT NULL`:
+Nullability for a non-nullable column can be changed using `DROP NOT NULL`:
```sql
ALTER TABLE prod.db.sample ALTER COLUMN id DROP NOT NULL
```
+{{< hint info >}}
+It is not possible to change a nullable column to non-nullable with `SET NOT
NULL` because Iceberg doesn't know whether there is existing data with null
values.
Review Comment:
addressed the first part, but `...there is existing data with...` is
gramatically correct and having `..an existing data...` would rather make it
incorrect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
