nastra commented on code in PR #7996:
URL: https://github.com/apache/iceberg/pull/7996#discussion_r1267613963
##########
delta-lake/src/integration/java/org/apache/iceberg/delta/TestSnapshotDeltaLakeTable.java:
##########
@@ -77,35 +77,32 @@ public class TestSnapshotDeltaLakeTable extends
SparkDeltaLakeSnapshotTestBase {
private static Dataset<Row> typeTestDataFrame;
private static Dataset<Row> nestedDataFrame;
- @Parameterized.Parameters(name = "Catalog Name {0} - Options {2}")
- public static Object[][] parameters() {
- return new Object[][] {
- new Object[] {
- icebergCatalogName,
- SparkCatalog.class.getName(),
- ImmutableMap.of(
- "type",
- "hive",
- "default-namespace",
- "default",
- "parquet-enabled",
- "true",
- "cache-enabled",
- "false" // Spark will delete tables using v1, leaving the cache
out of sync
- )
- }
- };
+ public static Stream<Arguments> parameters() {
Review Comment:
I think we can remove `public` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
