ggershinsky commented on code in PR #3231:
URL: https://github.com/apache/iceberg/pull/3231#discussion_r1264953929
##########
core/src/main/java/org/apache/iceberg/encryption/Ciphers.java:
##########
@@ -96,33 +110,45 @@ public AesGcmDecryptor(byte[] keyBytes) {
}
public byte[] decrypt(byte[] ciphertext, byte[] aad) {
- int plainTextLength = ciphertext.length - GCM_TAG_LENGTH - NONCE_LENGTH;
- Preconditions.checkState(plainTextLength >= 1,
+ return decrypt(ciphertext, 0, ciphertext.length, aad);
+ }
+
+ public byte[] decrypt(byte[] ciphertext, int ciphertextOffset, int
ciphertextLength, byte[] aad) {
Review Comment:
Unfortunately, this change triggers
> Execution failed for task ':iceberg-core:revapi'.
> > There were Java public API/ABI breaks reported by revapi:
> java.method.removed: Method was removed.
How this should be handled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
