nastra commented on code in PR #8050:
URL: https://github.com/apache/iceberg/pull/8050#discussion_r1262080986
##########
core/src/test/java/org/apache/iceberg/TestTableMetadata.java:
##########
@@ -1324,6 +1324,16 @@ public void testParseSchemaIdentifierFields() throws
Exception {
Assert.assertEquals(Sets.newHashSet(1, 2),
parsed.schemasById().get(1).identifierFieldIds());
}
+ @Test
+ public void testParseMinimal() throws Exception {
+ String data =
readTableMetadataInputFile("TableMetadataV2ValidMinimal.json");
+ TableMetadata parsed = TableMetadataParser.fromJson(data);
+ Assert.assertEquals(Lists.newArrayList(), parsed.snapshots());
Review Comment:
nit: Iceberg is currently migrating away from JUnit4, meaning that it later
adds additional work to convert these JUnit4-style assertions. It would be
great to update these to AssertJ.
```
assertThat(parsed.snapshots()).isEmpty();
assertThat(parsed.snapshotLog()).isEmpty();
assertThat(parsed.properties()).isEmpty();
assertThat(parsed.previousFiles()).isEmpty();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
