fskorgen opened a new issue, #6981:
URL: https://github.com/apache/hop/issues/6981
### Apache Hop version?
2.18
### Java version?
21
### Operating system
Windows
### What happened?
We have a MultiUnion transform supporting multiple inputs with different
metadata. This transform has worked fine for many years, but since version 2.18
it can sometimes halt because the wrong BlockingRowSet is removed when
processing completes. This appears to be caused by issues in the following
methods:
BaseRowSet::compareTo
BaseRowSet::equals
BaseRowSet::hashCode
The problem is that the following fields are not unique:
* remoteHopServerName
* destinationTransformName
* destinationTransformCopy
As a result, RowSet instances may be incorrectly identified as equal,
leading to removal of the wrong element from the internal ArrayList.
Including 'originTransformName' in the comparison logic ensures uniqueness
and results in the correct BlockingRowSet being removed.
The following change fixed the problem for me (BaseRowSet):
/**
* Compares using the target transforms and copy, not the source. That
way, re-partitioning is
* always done in the same way.
*/
@Override
public int compareTo(@NonNull IRowSet rowSet) {
lock.readLock().lock();
String target;
try {
target =
remoteHopServerName
+ "."
+ destinationTransformName
+ "."
+ destinationTransformCopy.intValue()
+ "."
+ originTransformName; // ADDED
} finally {
lock.readLock().unlock();
}
String comp =
rowSet.getRemoteHopServerName()
+ "."
+ rowSet.getDestinationTransformName()
+ "."
+ rowSet.getDestinationTransformCopy()
+ "."
+ rowSet.getOriginTransformName(); // ADDED
return target.compareTo(comp);
}
@Override
public boolean equals(Object o) {
if (this == o) {
return true;
}
if (!(o instanceof IRowSet other)) {
return false;
}
return compareTo(other) == 0;
}
@Override
public int hashCode() {
return Objects.hash(
remoteHopServerName,
destinationTransformName,
destinationTransformCopy.get(),
originTransformName); // ADDED
}
### Issue Priority
Priority: 1
### Issue Component
Component: Transforms
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
