Sigma-Ma opened a new pull request, #8891:
URL: https://github.com/apache/hbase/pull/8891

   JIRA: https://issues.apache.org/jira/browse/HBASE-29355.
   
   ## What changes were proposed in this pull request?
   
   - Attach the shared static UI resources and LICENSE/NOTICE files as an 
`hbase-server` artifact with the `static-resources` classifier during 
`process-resources`.
   - Declare provided dependencies in REST and Thrift and unpack the classified 
artifact during `generate-resources`.
   - Preserve the external webapps layout and the existing main-JAR exclusions.
   - Correct bundled library versions and copyright declarations, add the 
Tablesorter attribution, and include Vega-family licenses in the binary 
distribution.
   - Add classifier and InfoServer regression tests, plus a 
standard-library-only Python checker for the final artifacts.
   
   ## Why are the changes needed?
   
   REST and Thrift currently copy shared resources from the build directory of 
`hbase-server`. Installing the server artifact does not recreate that 
directory, so a clean module-only build can succeed without the required UI 
resources.
   
   It can also consume stale files from a neighboring build. Missing resources 
can prevent InfoServer from starting.
   
   The classified artifact makes the resource input available through Maven and 
removes the dependency on the neighboring build directory.
   
   ## How was this patch tested?
   
   ```bash
   
   mvn -B -ntp -o -T2 -pl hbase-rest,hbase-thrift -am -DskipTests clean compile
   
   mvn -B -ntp -o -pl hbase-server,hbase-rest,hbase-thrift 
-Dtest=TestStaticResources,TestRESTStaticResources,TestThriftStaticResources 
-Dsurefire.failIfNoSpecifiedTests=true -Dsurefire.rerunFailingTestsCount=0 test
   
   mvn -B -ntp -o -pl hbase-assembly -am -DskipTests package assembly:single
   
   python3 dev-support/check-static-resources.py
   
   mvn -B -ntp -o -pl 
.,hbase-resource-bundle,hbase-server,hbase-rest,hbase-thrift,hbase-assembly 
spotless:check
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to