Sigma-Ma commented on code in PR #174:
URL: https://github.com/apache/hbase-connectors/pull/174#discussion_r4571587575
##########
spark4/hbase-spark4/src/main/scala/org/apache/hadoop/hbase/spark/datasources/HBasePartitionReader.scala:
##########
@@ -174,8 +174,10 @@ class HBasePartitionReader(
properties.get(HBaseSparkConf.QUERY_CACHEDROWS).map(_.toInt).foreach {
rows =>
if (rows > 0) scan.setCaching(rows)
}
- properties.get(HBaseSparkConf.QUERY_BATCHSIZE).map(_.toInt).foreach {
batch =>
- if (batch > 0) scan.setBatch(batch)
+ properties.get(HBaseSparkConf.QUERY_BATCHSIZE).map(_.toInt).foreach {
+ batch =>
+ // Cell batches would expose incomplete rows to NULL predicates.
Review Comment:
Added this too. We now log a warning when a positive batch size is ignored.
Zero and negative values stay quiet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]