kgeisz commented on PR #8845:
URL: https://github.com/apache/hbase/pull/8845#issuecomment-6864462625
Hey @anmolnar and @VladRodionov, I have addressed some additional comments
again. These include:
- Removed log message verification in `TestFullBackupMarkerFailure` (per
@anmolnar's suggestion).
- Updated docstring for `HBackupFileSystem.writeBackupCompleteMarker()`.
- The docstring no longer says the user can fallback to
`.backup.manifest` if the `.backup.complete` marker file is missing.
- It now says a backup can still be complete if the marker file is
missing, but this can only be verified using the originating cluster's
`BackupSystemTable`.
- During a backup merge, the `.backup.complete` marker file is not copied
into the backup directory until the merge is actually complete.
- `TestBackupRepair` enhancement - Add a stale `.backup.complete` marker to
a backup and verify a repair deletes the file.
- Updated `TestIncrementalBackupMergeWithFailures.run()` to match
`MapReduceBackupMergeJob.run()` so it also waits until the merge is done to add
a `.backup.complete` marker file.
- Also verifies the marker file still exists after a failure before the
merge operation.
- Verifies the marker file does not exist after a failure during the
actual merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]