kgeisz commented on PR #8809: URL: https://github.com/apache/hbase/pull/8809#issuecomment-6862485683
Hey @anmolnar, I have addressed the first three points in your most recent review For 1 and 2, I addressed them as suggested - Kill `org.jruby.JarBootstrapMain` rather than `org.jruby.Main.*shell`, and throw an error if the list of tables cannot be parsed. For 3, I chose to keep the `zoo.cfg` file and have the hostname get modified when `hbase-site.xml` gets modified. I will make a Jira ticket and address the other comments in another PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
