nirdosh0110 commented on PR #8870:
URL: https://github.com/apache/hbase/pull/8870#issuecomment-6825317805
Reproduced locally with the new `TestHadoopSnappyCodec` by overriding
`snappy.version`:
```
mvn -pl hbase-common test -Dtest=TestHadoopSnappyCodec
-Dsnappy.version=<version>
```
| snappy-java | Result |
|---|---|
| 1.1.10.9 (current master) | ERROR |
| 1.1.10.10 | ERROR |
| 1.1.10.11 | PASS |
| 1.1.10.12 (this PR) | PASS |
Failure on 1.1.10.9:
```
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0 <<< FAILURE! -- in
org.apache.hadoop.hbase.io.compress.TestHadoopSnappyCodec
org.apache.hadoop.hbase.io.compress.TestHadoopSnappyCodec.testRoundTrip <<<
ERROR!
java.lang.IllegalArgumentException: not enough space for output: need
254,857 bytes, but only 0 remaining
at org.xerial.snappy.Snappy.checkOutputSpace(Snappy.java:613)
at org.xerial.snappy.Snappy.compress(Snappy.java:160)
at
org.apache.hadoop.io.compress.snappy.SnappyCompressor.compressDirectBuf(SnappyCompressor.java:282)
at
org.apache.hadoop.io.compress.snappy.SnappyCompressor.compress(SnappyCompressor.java:210)
at
org.apache.hadoop.io.compress.BlockCompressorStream.compress(BlockCompressorStream.java:149)
at
org.apache.hadoop.io.compress.BlockCompressorStream.write(BlockCompressorStream.java:115)
at
org.apache.hadoop.hbase.io.compress.Compression$FinishOnFlushCompressionStream.write(Compression.java:112)
at
java.base/java.io.BufferedOutputStream.write(BufferedOutputStream.java:123)
at
org.apache.hadoop.hbase.io.compress.TestHadoopSnappyCodec.testRoundTrip(TestHadoopSnappyCodec.java:61)
```
This is the same path HFile block compression takes for SNAPPY column
families with the default `hbase.io.compress.snappy.codec`, so flushes and
compactions on those families would fail with 1.1.10.9.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
