wchevreuil commented on code in PR #8737:
URL: https://github.com/apache/hbase/pull/8737#discussion_r4194004111
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##########
@@ -793,11 +796,8 @@ void blockEvicted(BlockCacheKey cacheKey, BucketEntry
bucketEntry, boolean decre
}
}
- private void fileNotFullyCached(BlockCacheKey key, BucketEntry entry) {
- // Update the updateRegionCachedSize before removing the file from
fullyCachedFiles.
- // This computation should happen even if the file is not in
fullyCachedFiles map.
- updateRegionCachedSize(key, (entry.getLength() * -1));
- fullyCachedFiles.remove(key.getHfileName());
+ private void fileNotFullyCached(String hfileName) {
Review Comment:
nit: since fileNotFullyCached now became a single liner delegation to
fullyCachedFiles.remove, can we remove fileNotFullyCached altogether and simply
call the fullyCachedFiles.remove directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
