taklwu commented on code in PR #8522:
URL: https://github.com/apache/hbase/pull/8522#discussion_r3716699018
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDataTieringManager.java:
##########
@@ -234,7 +234,13 @@ public void testPrefetchWhenDataTieringEnabled() throws
IOException {
// Since we have one cold file among four files, only three should get
prefetched.
Optional<Map<String, Pair<String, Long>>> fullyCachedFiles =
blockCache.getFullyCachedFiles();
assertTrue(fullyCachedFiles.isPresent(), "We should get the fully cached
files from the cache");
- Waiter.waitFor(defaultConf, 10000, () -> fullyCachedFiles.get().size() ==
3);
+ try {
+ Waiter.waitFor(defaultConf, 10000, () -> fullyCachedFiles.get().size()
== 3);
+ } catch (Throwable e) {
+ System.out.println("fullyCachedFiles = " +
blockCache.getFullyCachedFiles());
+ System.out.println("cacheAccessService = " +
cacheConf.getCacheAccessService().getClass());
+ System.out.println("isCombinedBlockCache = " +
cacheConf.isCombinedBlockCache());
Review Comment:
should we use logger `LOG` ?
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java:
##########
@@ -353,7 +353,7 @@ private CacheAccessService
initCombinedBlockCacheBackedService(final String l1Ca
that.set(BLOCKCACHE_POLICY_KEY, l1CachePolicy);
CacheAccessService bc =
CacheAccessServiceTestFactory.fromConfiguration(that);
assertNotNull(bc);
- assertTrue(CacheAccessServiceTestFactory.blockCache(bc) instanceof
CombinedBlockCache);
+ // assertTrue(CacheAccessServiceTestFactory.blockCache(bc) instanceof
CombinedBlockCache);
Review Comment:
this seems off, please see if we need this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
