[
https://issues.apache.org/jira/browse/HBASE-29984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18099957#comment-18099957
]
mazhengxuan edited comment on HBASE-29984 at 7/29/26 6:50 AM:
--------------------------------------------------------------
{{I have opened a PR for this issue:
[https://github.com/apache/hbase/pull/8512].}}
The patch updates IncrementalBackupManager to recursively collect archived WAL
files, supporting both the flat old WAL layout and the per-RegionServer layout
enabled by hbase.separate.oldlogdir.by.regionserver.
It also adds a regression test covering incremental backup log collection from
a RegionServer-specific old WAL directory.
{{The focused test was run with:}}
{code:bash}
mvn -pl hbase-backup -am \
-DskipITs \
-Dtest=TestIncrementalBackupManager \
-Dsurefire.failIfNoSpecifiedTests=false \
test{code}
was (Author: JIRAUSER298959):
{{I have opened a PR for this issue:
[https://github.com/apache/hbase/pull/8512].}}
The patch updates IncrementalBackupManager to recursively collect archived WAL
files, supporting both the flat old WAL layout and the per-RegionServer layout
enabled by hbase.separate.oldlogdir.by.regionserver.
It also adds a regression test covering incremental backup log collection from
a RegionServer-specific old WAL directory.
{{The focused test was run with:}}
{code:bash}
mvn -pl hbase-backup -am \
-DskipITs \
-Dtest=TestIncrementalBackupManager \
-Dsurefire.failIfNoSpecifiedTests=false \
test{code}
> Backup log collection can fail
> ------------------------------
>
> Key: HBASE-29984
> URL: https://issues.apache.org/jira/browse/HBASE-29984
> Project: HBase
> Issue Type: Bug
> Components: backup&restore
> Affects Versions: 4.0.0-alpha-1, 3.0.0-beta-2, 2.6.4
> Reporter: Dieter De Paepe
> Assignee: mazhengxuan
> Priority: Major
> Labels: pull-request-available
>
> Found during
> [review|https://github.com/apache/hbase/pull/7582/changes/e1c25329acf26792bbf4faed98a44fab647e39d2#r2676601419]
> of HBASE-29776.
> The backup logic scans the logs and oldlogs:
> * IncrementalBackupManager#getLogFilesForNewBackup
> * (Introduced in HBASE-29776) FullTableBackupClient#execute
> It assumes old logs are files under the "oldWals" folder.
> However, there's a configuration key hbase.separate.oldlogdir.by.regionserver
> that can change this behavior. When set to true, the old logs are stored in
> directories under "oldWals". The backup code will error on this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
