kgeisz commented on code in PR #8377:
URL: https://github.com/apache/hbase/pull/8377#discussion_r3560536422
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/util/ConfigurationUtil.java:
##########
@@ -116,8 +116,22 @@ public static List<Map.Entry<String, String>>
getKeyValues(Configuration conf, S
return rtn;
}
+ /**
+ * Returns true if the provided Configuration object has
+ * {@link HConstants#HBASE_GLOBAL_READONLY_ENABLED_KEY} set to true; false
otherwise.
+ */
public static boolean isReadOnlyModeEnabledInConf(Configuration conf) {
return conf.getBoolean(HConstants.HBASE_GLOBAL_READONLY_ENABLED_KEY,
HConstants.HBASE_GLOBAL_READONLY_ENABLED_DEFAULT);
}
+
+ /**
+ * Returns a copied version of the provided Configuration object that has
+ * {@link HConstants#HBASE_GLOBAL_READONLY_ENABLED_KEY} set to true.
+ */
+ public static Configuration
getReadOnlyEnabledConfigurationCopy(Configuration conf) {
Review Comment:
IMO the name should use `get` instead of `set` since the method returns a
modified copy of the configuration. The original configuration is left
untouched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
