VladRodionov commented on code in PR #8276:
URL: https://github.com/apache/hbase/pull/8276#discussion_r3390902479


##########
hbase-common/src/main/resources/hbase-default.xml:
##########
@@ -1926,6 +1926,15 @@ possible configurations would overwhelm and obscure the 
important.
       The default value is one week.
     </description>
   </property>
+  <property>
+    <name>hbase.mob.compaction.cache.blocks</name>

Review Comment:
   Minor naming/documentation question: the config name 
hbase.mob.compaction.cache.blocks is understandable, but the behavior is 
specifically about caching blocks while reading existing MOB files during 
compaction, not cache-on-write of compaction output. To avoid confusion with 
cache-on-write settings, would a more explicit name such as 
hbase.mob.compaction.read.cache.blocks or 
hbase.mob.compaction.cache.blocks.on.read be clearer?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to