junegunn commented on code in PR #8321:
URL: https://github.com/apache/hbase/pull/8321#discussion_r3368488933
##########
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HashTable.java:
##########
@@ -665,7 +679,7 @@ private boolean doCommandLine(final String[] args) {
for (int i = 0; i < args.length - NUM_ARGS; i++) {
String cmd = args[i];
- if (cmd.equals("-h") || cmd.startsWith("--h")) {
+ if (cmd.equals("-h") || cmd.equals("--help")) {
Review Comment:
Interesting. I think the intention here was to support the long option
`--help`. How about adding an equals condition for `--help`?
EDIT: Nevermind, I misread the code.
##########
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HashTable.java:
##########
@@ -665,7 +679,7 @@ private boolean doCommandLine(final String[] args) {
for (int i = 0; i < args.length - NUM_ARGS; i++) {
String cmd = args[i];
- if (cmd.equals("-h") || cmd.startsWith("--h")) {
+ if (cmd.equals("-h") || cmd.equals("--help")) {
Review Comment:
Interesting. I think the intention here was to support the long option
`--help`. How about adding an equals condition for `--help`?
EDIT: Nevermind, I misread the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
