apurtell commented on code in PR #7864:
URL: https://github.com/apache/hbase/pull/7864#discussion_r3277672206
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcExecutor.java:
##########
@@ -466,7 +459,15 @@ public void resizeQueues(Configuration conf) {
}
}
final int queueLimit = currentQueueLimit;
- currentQueueLimit = conf.getInt(configKey, queueLimit);
+ int newQueueLimit = conf.getInt(configKey, queueLimit);
+ if (newQueueLimit > queueHardLimit) {
+ LOG.warn(
+ "Requested soft limit {} exceeds queue hard limit/capacity {}. "
+ + "A region server restart is required to grow the underlying
queue.",
+ newQueueLimit, queueHardLimit);
+ newQueueLimit = DEFAULT_CALL_QUEUE_SIZE_HARD_LIMIT;
Review Comment:
Shouldn't this be `newQueueLimit = queueHardLimit;` ?
Also it would be cleaner to declare this `protected final int
queueHardLimit;` because it's never changed outside of the constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
