junegunn commented on PR #8134: URL: https://github.com/apache/hbase/pull/8134#issuecomment-4367913044
Thanks, here are my initial thoughts. ### Pluggable `RowKeyProgress` feels like overkill Allowing a custom class gives maximum flexibility, but I think few users will author and deploy a custom class just for an optional progress signal. It costs us an `@InterfaceAudience.Public` interface to maintain. Could we drop it and pick the algorithm via a simple string config (e.g. `uniform` / `hex`)? ### Naming could align with `RegionSplitter` Users already know `HexStringSplit`, `UniformSplit`, and `DecimalStringSplit` from `RegionSplitter`. But this PR introduces new vocabulary (`HexPrefix`, `ByteBased`) for the similar, albeit not identical, concepts. Can we reuse the existing words? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
