Copilot commented on code in PR #8121:
URL: https://github.com/apache/hbase/pull/8121#discussion_r3135470552
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java:
##########
@@ -609,13 +603,13 @@ public void testExceedTableQuotaInNamespace() throws
Exception {
ADMIN.createTable(tableDescTwo, Bytes.toBytes("AAA"),
Bytes.toBytes("ZZZ"), 4);
}
Review Comment:
`testExceedTableQuotaInNamespace` used to assert an expected
`QuotaExceededException` via JUnit4's `@Test(expected=...)`, but the JUnit5
migration removed the expected-exception behavior and the test now calls
`ADMIN.createTable(tableDescTwo, ...)` without asserting the exception. This
will either fail by throwing the exception or silently stop validating the
quota behavior if it no longer throws. Wrap the second createTable in
`assertThrows(QuotaExceededException.class, ...)` (and consider asserting
message/cause if useful).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
