Copilot commented on code in PR #8118:
URL: https://github.com/apache/hbase/pull/8118#discussion_r3130207480
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestReopenTableRegionsProcedureSpecificRegions.java:
##########
@@ -407,8 +402,8 @@ public void testEmptyTableWithNoRegions() throws Exception {
long procId = getProcExec().submitProcedure(proc);
ProcedureTestingUtility.waitProcedure(getProcExec(), procId);
- assertFalse("Procedure should complete successfully even with no regions",
proc.isFailed());
- assertEquals("Should handle empty table gracefully", regionCount,
proc.getRegionsReopened());
+ assertFalse(proc.isFailed(), "Procedure should complete successfully even
with no regions");
+ assertEquals(proc.getRegionsReopened(), regionCount, "Should handle empty
table gracefully");
Review Comment:
`assertEquals` has the expected/actual arguments swapped here (expected
should be `regionCount`, actual should be `proc.getRegionsReopened()`). This
won't change pass/fail semantics but it will produce misleading assertion
diagnostics on failure; please swap the first two arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
