liuxiaocs7 commented on code in PR #8113:
URL: https://github.com/apache/hbase/pull/8113#discussion_r3129216165
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterQosFunction.java:
##########
@@ -46,23 +44,20 @@
import org.apache.hadoop.hbase.shaded.protobuf.generated.HBaseProtos;
import
org.apache.hadoop.hbase.shaded.protobuf.generated.RegionServerStatusProtos;
-@Category({ MasterTests.class, SmallTests.class })
+@Tag(MasterTests.TAG)
+@Tag(SmallTests.TAG)
public class TestMasterQosFunction extends QosTestHelper {
- @ClassRule
- public static final HBaseClassTestRule CLASS_RULE =
- HBaseClassTestRule.forClass(TestMasterQosFunction.class);
-
private Configuration conf;
private RSRpcServices rpcServices;
private AnnotationReadingPriorityFunction qosFunction;
- @Before
+ @BeforeEach
public void setUp() {
conf = HBaseConfiguration.create();
rpcServices = Mockito.mock(MasterRpcServices.class);
when(rpcServices.getConfiguration()).thenReturn(conf);
- qosFunction = new MasterAnnotationReadingPriorityFunction(rpcServices,
MasterRpcServices.class);
+ qosFunction = new MasterAnnotationReadingPriorityFunction(rpcServices);
}
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
