Copilot commented on code in PR #8067: URL: https://github.com/apache/hbase/pull/8067#discussion_r3072082821
########## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCrossCFSeekHint.java: ########## @@ -0,0 +1,209 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.regionserver; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertTrue; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.List; +import java.util.stream.Stream; +import org.apache.hadoop.hbase.Cell; +import org.apache.hadoop.hbase.CellUtil; +import org.apache.hadoop.hbase.HBaseTestingUtil; +import org.apache.hadoop.hbase.KeyValue; +import org.apache.hadoop.hbase.TableName; +import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder; +import org.apache.hadoop.hbase.client.Put; +import org.apache.hadoop.hbase.client.RegionInfo; +import org.apache.hadoop.hbase.client.RegionInfoBuilder; +import org.apache.hadoop.hbase.client.Scan; +import org.apache.hadoop.hbase.client.TableDescriptor; +import org.apache.hadoop.hbase.client.TableDescriptorBuilder; +import org.apache.hadoop.hbase.filter.FilterBase; +import org.apache.hadoop.hbase.testclassification.MediumTests; +import org.apache.hadoop.hbase.testclassification.RegionServerTests; +import org.apache.hadoop.hbase.util.Bytes; +import org.junit.jupiter.api.Tag; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.Arguments; +import org.junit.jupiter.params.provider.MethodSource; + +/** + * Test that SEEK_NEXT_USING_HINT with a hint pointing to a different column family does not degrade + * into cell-by-cell traversal. + * <p> + * HBASE-28902: StoreScanner uses InnerStoreCellComparator which compares column families by length + * only (an optimization valid within a single store). When the filter hint points to a different + * CF, this comparison can produce the wrong result, causing the seek to be skipped and falling back + * to heap.next() for every cell. + */ +@Tag(RegionServerTests.TAG) +@Tag(MediumTests.TAG) +public class TestCrossCFSeekHint { + + private static final HBaseTestingUtil TEST_UTIL = new HBaseTestingUtil(); + + private static final byte[] ROW1 = Bytes.toBytes("row1"); + private static final byte[] ROW2 = Bytes.toBytes("row2"); + private static final byte[] QUAL = Bytes.toBytes("q"); + private static final int NUM_CELLS = 100; + + // Two CFs with different lengths: "aa" sorts first, "b" sorts second. + private static final byte[] CF_FIRST = Bytes.toBytes("aa"); + private static final byte[] CF_SECOND = Bytes.toBytes("b"); + + // Two CFs with same length: "aa" sorts first, "bb" sorts second. + private static final byte[] CF_SECOND_SAME_LEN = Bytes.toBytes("bb"); + + static Stream<Arguments> params() { + return Stream.of( + // Forward scan: data in "aa" (first), hint to "b" (second). Different lengths. + Arguments.of(CF_FIRST, CF_SECOND, true, false), + Arguments.of(CF_FIRST, CF_SECOND, false, false), + // Forward scan: data in "aa" (first), hint to "bb" (second). Same lengths. + Arguments.of(CF_FIRST, CF_SECOND_SAME_LEN, true, false), + Arguments.of(CF_FIRST, CF_SECOND_SAME_LEN, false, false), + // Reverse scan: data in "b" (second), hint to "aa" (first). Different lengths. + Arguments.of(CF_SECOND, CF_FIRST, true, true), Arguments.of(CF_SECOND, CF_FIRST, false, true), Review Comment: This line likely violates the repo's 100-character LineLength checkstyle rule. Please wrap the two Arguments.of(...) entries onto separate lines (or otherwise reformat) so each line stays within the limit. ```suggestion Arguments.of(CF_SECOND, CF_FIRST, true, true), Arguments.of(CF_SECOND, CF_FIRST, false, true), ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
