vaijosh commented on code in PR #8049:
URL: https://github.com/apache/hbase/pull/8049#discussion_r3057894170
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestReadOnlyControllerBulkLoadObserver.java:
##########
@@ -58,12 +58,12 @@ public void tearDown() throws Exception {
}
- @Test(expected = DoNotRetryIOException.class)
+ @Test(expected = WriteAttemptedOnReadOnlyClusterException.class)
Review Comment:
Hi @sharmaar12
Since we’ve migrated to JUnit 5, we should move away from the outdated
expected parameter in the @Test annotation. Please use assertThrows instead.
Additionally, the current tests don't verify the exception message—using
assertThrows will allow you to capture the exception and assert against the
message. While the old pattern might work for legacy branches, we need to
follow the new standard for any merges into master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
