charlesconnell commented on code in PR #2142:
URL: https://github.com/apache/hbase/pull/2142#discussion_r3040109571
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaObserverChore.java:
##########
Review Comment:
Do you need a `QuotaUtil.disableTableIfNotDisabled(conn, tableInNS);` call
here too?
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaObserverChore.java:
##########
@@ -433,6 +433,11 @@ void updateNamespaceQuota(
LOG.info(tableInNS + " moving into violation of namespace space
quota with policy "
+ targetStatus.getPolicy());
this.snapshotNotifier.transitionTable(tableInNS, targetSnapshot);
+ // when the Namespace is in violation due to Disable Policy,
Disable the table
+ if (targetStatus.isInViolation()
Review Comment:
`targetStatus.isInViolation()` is already guaranteed to be true if we reach
this line, you don't need to check again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
