charlesconnell commented on code in PR #1069:
URL: https://github.com/apache/hbase/pull/1069#discussion_r3040022548
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:
##########
@@ -3699,9 +3682,11 @@ public void
prepareMiniBatchOperations(MiniBatchOperationInProgress<Mutation> mi
if (mutation instanceof Put) {
HRegion.updateCellTimestamps(familyCellMaps[index].values(), byteTS);
miniBatchOp.incrementNumOfPuts();
+ miniBatchOp.incrementBytesForPuts(mutation.heapSize());
Review Comment:
I too am concerned about the cost of evaluating `heapSize()` in a hot code
path. Also, this is not the best estimate of the wire size of the put.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
