dParikesit opened a new pull request, #7995:
URL: https://github.com/apache/hbase/pull/7995

   JIRA: [HBASE-30038](https://issues.apache.org/jira/browse/HBASE-30038)
   
   This bug is similar to 
[HBASE-28890](https://issues.apache.org/jira/browse/HBASE-28890)
   
   HFileBlock.Writer.getBlockForCaching() creates a ref-counted HFileBlock, and 
the caller must release its own reference after the cache has taken the 
ownership it needs. 
   
   In HFileWriterImpl.java, the leak happened when shouldCacheBlock() returned 
before cacheFormatBlock.release() ran.
   
   In HFileBlockIndex.java, the intermediate-index path cached blockForCaching 
but never released the reference at all. 
   
   Because these blocks can be backed by pooled off-heap ByteBuffs, repeated 
HFile writes could steadily drain allocator buffers and effectively leak 
memory, even though the blocks were only meant to live long enough to be 
considered for cache-on-write.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to