vaijosh commented on code in PR #7994:
URL: https://github.com/apache/hbase/pull/7994#discussion_r3004751673
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/FullTableBackupClient.java:
##########
@@ -178,12 +178,12 @@ public void execute() throws IOException {
Map<TableName, Map<String, Long>> newTableSetTimestampMap =
backupManager.readLogTimestampMap();
- backupManager
-
.deleteBulkLoadedRows(bulkLoadsToDelete.stream().map(BulkLoad::getRowKey).toList());
-
// backup complete
backupInfo.setTableSetTimestampMap(newTableSetTimestampMap);
completeBackup(conn, backupInfo, BackupType.FULL, conf);
+
+ backupManager
+
.deleteBulkLoadedRows(bulkLoadsToDelete.stream().map(BulkLoad::getRowKey).toList());
} catch (Exception e) {
failBackup(conn, backupInfo, backupManager, e, "Unexpected
BackupException : ",
Review Comment:
Hi @nazuhifu
What happens if the backup completes successfully but a failure occurs
during the deleteBulkLoadedRows call? In that case, it appears the operation is
reported as a BackupFailure, even though the backup itself succeeded and only
the post-cleanup step failed.
Can we improve this behavior to distinguish between backup success and
cleanup failure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
