sharmaar12 commented on code in PR #7922:
URL: https://github.com/apache/hbase/pull/7922#discussion_r2932155128


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AbstractReadOnlyController.java:
##########


Review Comment:
   @anmolnar  On the contrary to above discussion, I think we should throw 
exception here as this case will cause data corruption because you are not able 
to create the cluster file but you now cluster is active.
   
   I also think, even if this throw exception, then master will not change its 
readonly state. But how can we notify Region's OnConfigurationChange to abort 
changing the state because I think calls to configuration observers are 
executed in parallel.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to