janvanbesien commented on code in PR #7761:
URL: https://github.com/apache/hbase/pull/7761#discussion_r2817178187
##########
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/master/TestBackupLogCleaner.java:
##########
@@ -215,6 +216,59 @@ public void testBackupLogCleaner() throws Exception {
}
}
+ @Test
+ public void testRemovedTableDoesNotPinWals() throws Exception {
Review Comment:
Thanks for your review dieter.
As I understand it, the problem can be triggered by explicitly removing a
table from the backup (i.e. explicitly deciding to no longer backup said table)
or by removing the table completely (i.e. implicitly it is no longer in any
future backup either). You're right that I mixed the two cases and that the
primary trigger was the latter, not the former.
I now have a test for both scenarios. Does that make sense?
Also updated commit message and rebased on master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
