liuxiaocs7 commented on code in PR #7726:
URL: https://github.com/apache/hbase/pull/7726#discussion_r2791267880
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/util/MemorySizeUtil.java:
##########
@@ -300,6 +322,20 @@ public static long getOnHeapCacheSize(final Configuration
conf) {
}
}
+ /**
+ * Retrieve an explicit memstore size in bytes in the configuration.
+ * @param conf used to read memstore configs
+ * @return the number of bytes to use for memstore, negative if not
configured.
+ * @throws IllegalArgumentException if {@code MEMSTORE_MEMORY_SIZE_KEY}
format is invalid
+ */
+ public static long getMemstoreSizeInBytes(Configuration conf) {
+ try {
+ return Long.parseLong(conf.get(MEMSTORE_MEMORY_SIZE_KEY, "-1"));
Review Comment:
Hi, @ndimiduk, sure, we support human-friendly values, just like in
blockcache, and I add some more test cases in jira, please help take a look
when free, thanks!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
