[
https://issues.apache.org/jira/browse/HBASE-29859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18056442#comment-18056442
]
Dávid Paksy commented on HBASE-29859:
-------------------------------------
Many thanks [~liuxiaocs] for the contribution! I pushed the patch to master,
branch-3 and branch-2.
Will wait to push it to branch-2.6 and branch-2.5 because of the ongoing
release creation.
> Initialization log for DataTieringManager is incorrect
> ------------------------------------------------------
>
> Key: HBASE-29859
> URL: https://issues.apache.org/jira/browse/HBASE-29859
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 3.0.0-beta-1, 2.6.4, 2.5.13
> Reporter: Xiao Liu
> Assignee: Xiao Liu
> Priority: Minor
> Labels: pull-request-available
> Fix For: 2.7.0, 3.0.0-beta-2
>
>
> In the \{{DataTieringManager.instantiate}} method, if \{{DataTieringFeature}}
> is not enabled, we still see the log message \{{DataTieringManager is already
> instantiated.}} when the regionserver starts, which is quite confusing. The
> code is as follows:
> {code:java}
> public static synchronized boolean instantiate(Configuration conf,
> Map<String, HRegion> onlineRegions) {
> if (isDataTieringFeatureEnabled(conf) && instance == null) {
> instance = new DataTieringManager(onlineRegions);
> LOG.info("DataTieringManager instantiated successfully.");
> return true;
> } else {
> LOG.warn("DataTieringManager is already instantiated.");
> }
> return false;
> } {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)