kgeisz opened a new pull request, #7702:
URL: https://github.com/apache/hbase/pull/7702

   https://issues.apache.org/jira/browse/HBASE-29780
   
   This pull request is an addendum to [HBASE-29715: AssignmentManager is 
trying to pick up the active cluster's tables before refreshing meta and 
hfiles](https://issues.apache.org/jira/browse/HBASE-29715).  This PR adds an 
additional test case that adds table descriptors to both the filesystem and the 
table descriptor cache, rather than just the cache.  This is done by using 
`false` instead of `true` for `cacheOnly` in 
[master.getTableDescriptors().update()](https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java#L334).
   
   I also noticed I could create the table descriptor on the filesystem by 
using the static `FSTableDescriptors.createTableDescriptorForTableDirectory()` 
method.  However, I would still need to run 
`master.getTableDescriptors().update()` after to update the cache.  If I didn't 
update the cache, then the new unit test would still pass even if I reverted 
the original change to HMaster introduced in the previous PR (#7474).  This is 
why I instead went with using `master.getTableDescriptors().update()` with 
`cacheOnly` set to `false` because it achieves the same result with fewer lines 
of code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to