guluo2016 commented on code in PR #7684:
URL: https://github.com/apache/hbase/pull/7684#discussion_r2746660935
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RegionReplicaReplicationEndpoint.java:
##########
@@ -440,7 +440,8 @@ public void append(TableName tableName, byte[]
encodedRegionName, byte[] row,
// keep going to the cache, we will not learn of the replicas and
their locations after
// they come online.
if (useCache && locations.size() == 1 &&
TableName.isMetaTableName(tableName)) {
- if (tableDescriptors.get(tableName).getRegionReplication() > 1) {
+ TableDescriptor td = tableDescriptors.get(tableName);
Review Comment:
Sorry, I just noticed a few additional concerns after approving
I found the issue doesn't seem to exist for branch-2.5.
The code is only executed when `seCache && locations.size() == 1 &&
TableName.isMetaTableName(tableName)` is true, whch means that it's meta table,
and the td of meta table is not null in here . right ? @krconv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
