hgromer commented on code in PR #7582:
URL: https://github.com/apache/hbase/pull/7582#discussion_r2668902625
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalBackupManager.java:
##########
Review Comment:
```java
Map<String, Long> newTimestamps =
rollTimestamps.entrySet().stream()
// Region servers that are offline since the last backup will have old
roll timestamps,
// prune their information here, as it is not relevant to be stored or
used for finding
// the relevant logs.
.filter(entry -> entry.getValue() > rollStartTs)
.collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue));
```
I'm not sure I necessarily agree with this logic. B/c the RS not being
rolled this go around doesn't mean we've backed up all the files from the RS we
need to backup. It just means the host doesn't exist on the cluster at the
moment.
1. Server A is backed up
2. Server A generate more WAL files
3. Server A is removed from cluster
4. New backup occurs, but we don't get a roll time for Server A so we ignore
its files
We need to backup the files that were generated between the last backup, and
this backup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
