Apache9 commented on code in PR #7591:
URL: https://github.com/apache/hbase/pull/7591#discussion_r2667265254
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceShipper.java:
##########
@@ -101,6 +104,10 @@ public final void run() {
LOG.info("Running ReplicationSourceShipper Thread for wal group: {}",
this.walGroupId);
// Loop until we close down
while (isActive()) {
+ // check if flush needed for WAL backup, this is need for timeout based
flush
+ if (shouldFlushStagedWal()) {
Review Comment:
The name is a bit confusing, which still assumes that the WAL entries we
send to ReplicationEndpoint are 'staged'...
Just name it 'shouldPersistLogPosition'. And we already have a
logPositionAndCleanOldLogs method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
