junegunn commented on code in PR #7588:
URL: https://github.com/apache/hbase/pull/7588#discussion_r2667095276
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/security/provider/AuthenticationProviderSelector.java:
##########
@@ -32,8 +32,8 @@
public interface AuthenticationProviderSelector {
/**
- * Initializes the implementation with configuration and a set of providers
available. This method
- * should be called exactly once per implementation prior to calling
+ * Initializes the implementation with configuration and a set of providers
available. For every
+ * selector instance, this method should be called exactly once prior to
calling
Review Comment:
We still have `exactly` in the sentence. Was that intentional?
IMO, the primary target audience for this comment is developers implementing
this interface, and they are not expected to call this method directly. From
that perspective, it might read more naturally in the passive voice. For
example:
> This method is called once upon construction, before selectProvider(...)
is invoked.
Just my two cents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
