kgeisz opened a new pull request, #7571:
URL: https://github.com/apache/hbase/pull/7571

   https://issues.apache.org/jira/browse/HBASE-29791
   
   This pull request back-ports [HBASE-29761: The HBase UI's Debug Dump is not 
redacting sensitive 
information](https://issues.apache.org/jira/browse/HBASE-29761) into branch-2.  
HBASE-29761 fixes an issue where sensitive information, such as passwords, were 
not being redacted when looking at a server's Debug Dump in the HBase UI.  
Similar to PR #7568 with branch-2, some small modifications needed to be made 
in the Java code in order to get this commit to build.  The changes included:
   
   ### MasterDumpServlet.java and RSDumpServlet.java
   
   - Using `StandardCharsets.UTF_8.toString()` instead of 
`StandardCharsets.UTF_8`
   
   ### MasterDumpServlet.java
   
   - Changed `if (isShowQueueDump(conf))` to `if 
(isShowQueueDump(master.getConfiguration()))` since the `conf` variable no 
longer exists in the code (the master branch does not have this `if` block at 
all).
   
   ### TestDebugDumpRedaction.java
   
   - Using `HBaseTestingUtility` instead of `HBaseTestingUtil`
   - Initializing `REDACTED_PROPS` using `Arrays.asList()` instead of 
`List.of()` and using `.collect(Collectors.toList()) ` instead of `.toList()`.
   
   ### TestServerHttpUtils.java
   
   - Using `static final String PLAIN_TEXT = "text/plain"` instead of `static 
final String PLAIN_TEXT_UTF8 = "text/plain;charset=utf-8"`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to