stoty commented on PR #7539: URL: https://github.com/apache/hbase/pull/7539#issuecomment-3643187422
> Since these libraries use commons-logging as their logging facade, excluding commons-logging may introduce troubles like ClassNotFoundException? Not if the the jcl-over-slf4j jar is present on the classpath. The jcl-over-slf4j jar implements the commons-logging API. The Hadoop dependency is actually via commons-configuration2, but we don't have dependency defined, hence I added the exclusion a level higher. We may have such problems if jcl-over-slf4j is omitted from the classpath. > And at least, we can not see the logs of these libraries? In my experience commons-logging logs are usually lost, or end up in some unexpeced place because HBase does not include commons-logging configuration. Using jcl-over-slf4j ensures that the commons-logging messages get piped into SLF4j and from there to Log4j2. We've done the same in Phoenix some time ago, and tested that the commons-logging components' logs are logged via lsf4j->log4j2 (there are very few, we had to work to trigger them) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
