Copilot commented on code in PR #7488:
URL: https://github.com/apache/hbase/pull/7488#discussion_r2591049646


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/util/MoveWithAck.java:
##########
@@ -80,7 +80,7 @@ public Boolean call() throws IOException, 
InterruptedException {
       }
       count = count + 1;
       admin.move(region.getEncodedNameAsBytes(), targetServer);
-      long maxWait = startTime + (maxWaitInSeconds * 1000);
+      long maxWait = EnvironmentEdgeManager.currentTime() + (maxWaitInSeconds 
* 1000);

Review Comment:
   Potential overflow in [int multiplication](1) before it is converted to long 
by use in a numeric context.
   ```suggestion
         long maxWait = EnvironmentEdgeManager.currentTime() + ((long) 
maxWaitInSeconds * 1000);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to