stoty commented on PR #7517: URL: https://github.com/apache/hbase/pull/7517#issuecomment-3613869130
> The naming and logic is a bit confusing here, we have a keepProgress field here, but we use it outside ScannerContext to determine whether we should call clearProgress, but for the keepBlockProgress, we use it inside the ScannerContext while calling the clearProgress method... Yes, this is a sub-case of the keepProgress=false case. I don't think pushing this logic to the StoreScanner would improve readability. I'm of course open to suggestions on changing names or implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
