[
https://issues.apache.org/jira/browse/HBASE-29734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18041152#comment-18041152
]
Deep Golani commented on HBASE-29734:
-------------------------------------
[~jc100102] I've raised the PR for this change; please review when you get a
chance.
and please let me know if I should open PRs for any other branches.
> MoveWithAck calculates the maxWait timeout wrong.
> -------------------------------------------------
>
> Key: HBASE-29734
> URL: https://issues.apache.org/jira/browse/HBASE-29734
> Project: HBase
> Issue Type: Bug
> Components: util
> Reporter: Jianfei Cheng
> Assignee: Deep Golani
> Priority: Major
> Labels: pull-request-available
>
> In MoveWithAck, [the maxWait timeout was calculated inside the retry
> loop|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/util/MoveWithAck.java#L83-L84]
> using a fixed startTime calculated at the out side of the retry loop,
> causing it to remain constant across all retry attempts. This means that each
> retry didn't really check isSameServer and marks all retries failed.
> To fix it, calculate maxWait based on the current time instead of sartTime
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
