hgromer commented on code in PR #7480:
URL: https://github.com/apache/hbase/pull/7480#discussion_r2560052754
##########
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java:
##########
@@ -443,23 +453,26 @@ private WriterLength getNewWriter(byte[] tableName,
byte[] family, Configuration
HFileContext hFileContext = contextBuilder.build();
if (null == favoredNodes) {
- wl.writer =
+ wi.writer =
new StoreFileWriter.Builder(conf, CacheConfig.DISABLED,
fs).withOutputDir(familydir)
.withBloomType(bloomType).withFileContext(hFileContext).build();
} else {
- wl.writer = new StoreFileWriter.Builder(conf, CacheConfig.DISABLED,
new HFileSystem(fs))
+ wi.writer = new StoreFileWriter.Builder(conf, CacheConfig.DISABLED,
new HFileSystem(fs))
.withOutputDir(familydir).withBloomType(bloomType).withFileContext(hFileContext)
.withFavoredNodes(favoredNodes).build();
}
- this.writers.put(tableAndFamily, wl);
- return wl;
+ this.writers.put(tableAndFamily, wi);
+ return wi;
}
- private void close(final StoreFileWriter w) throws IOException {
+ private void close(final StoreFileWriter w, final WriterInfo wl) throws
IOException {
Review Comment:
Small thing, mind changing `wl` to `wi` here to match the rest of the patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
