Umeshkumar9414 commented on code in PR #7375:
URL: https://github.com/apache/hbase/pull/7375#discussion_r2511776938
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java:
##########
@@ -232,12 +236,15 @@ public class AssignmentManager {
private final int forceRegionRetainmentRetries;
+ private final RegionInTransitionTracker regionInTransitionTracker;
Review Comment:
There are couple of reasons for this
- I wanted regionTransitionTracker to follow meta (RegionStateStore in code)
and regionStates doesn't do that. Sometime we update region state in memory and
update meta in next step of procedure.
-regionInTransitionTracker needed tableStateManager and I doesn't wanted to
pass tableStateManager to regionSates. Another option would be create tracker
in AssignmentManager itself and then pass that in constructor.
Considering above I feel keeping this in AM is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
