Apache-HBase commented on PR #7296:
URL: https://github.com/apache/hbase/pull/7296#issuecomment-3398930988

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 12s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  buf  |   0m  1s |  |  buf was not available.  |
   | +0 :ok: |  buf  |   0m  1s |  |  buf was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  |  Patch does not have any 
anti-patterns.  |
   |||| _ HBASE-29588-feature Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m 48s |  |  HBASE-29588-feature 
passed  |
   | +1 :green_heart: |  compile  |   6m 11s |  |  HBASE-29588-feature passed  |
   | +1 :green_heart: |  checkstyle  |   1m 18s |  |  HBASE-29588-feature 
passed  |
   | +1 :green_heart: |  spotbugs  |   5m 51s |  |  HBASE-29588-feature passed  
|
   | +1 :green_heart: |  spotless  |   1m  3s |  |  branch has no errors when 
running spotless:check.  |
   | -0 :warning: |  patch  |   1m 23s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
   |||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m 34s |  |  the patch passed  |
   | -1 :x: |  compile  |   1m 54s | 
[/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7296/21/artifact/yetus-general-check/output/patch-compile-hbase-server.txt)
 |  hbase-server in the patch failed.  |
   | -1 :x: |  cc  |   1m 54s | 
[/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7296/21/artifact/yetus-general-check/output/patch-compile-hbase-server.txt)
 |  hbase-server in the patch failed.  |
   | -0 :warning: |  javac  |   1m 54s | 
[/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7296/21/artifact/yetus-general-check/output/patch-compile-hbase-server.txt)
 |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  blanks  |   0m  1s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   0m 46s | 
[/results-checkstyle-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7296/21/artifact/yetus-general-check/output/results-checkstyle-hbase-server.txt)
 |  hbase-server: The patch generated 22 new + 38 unchanged - 0 fixed = 60 
total (was 38)  |
   | +1 :green_heart: |  xmllint  |   0m  0s |  |  No new issues.  |
   | -1 :x: |  spotbugs  |   3m  0s | 
[/new-spotbugs-hbase-server.html](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7296/21/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html)
 |  hbase-server generated 18 new + 0 unchanged - 0 fixed = 18 total (was 0)  |
   | +1 :green_heart: |  hadoopcheck  |  13m 30s |  |  Patch does not cause any 
errors with Hadoop 3.3.6 3.4.1.  |
   | +1 :green_heart: |  hbaseprotoc  |   1m 49s |  |  the patch passed  |
   | +1 :green_heart: |  spotless  |   0m 57s |  |  patch has no errors when 
running spotless:check.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 28s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  61m 40s |  |  |
   
   
   | Reason | Tests |
   |-------:|:------|
   | SpotBugs | module:hbase-server |
   |  |  Load of known null value in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.findSectionBloomState(boolean,
 boolean)  At AbstractMultiTenantReader.java:in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.findSectionBloomState(boolean,
 boolean)  At AbstractMultiTenantReader.java:[line 571] |
   |  |  Load of known null value in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.getFirstKey()  At 
AbstractMultiTenantReader.java:in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.getFirstKey()  At 
AbstractMultiTenantReader.java:[line 1657] |
   |  |  Load of known null value in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.getLastKey()  At 
AbstractMultiTenantReader.java:in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.getLastKey()  At 
AbstractMultiTenantReader.java:[line 1694] |
   |  |  Load of known null value in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.loadDataBlockIndexFromSection(byte[])
  At AbstractMultiTenantReader.java:in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.loadDataBlockIndexFromSection(byte[])
  At AbstractMultiTenantReader.java:[line 1800] |
   |  |  Load of known null value in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.loadMetaBlockFromSection(byte[],
 String, boolean)  At AbstractMultiTenantReader.java:in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.loadMetaBlockFromSection(byte[],
 String, boolean)  At AbstractMultiTenantReader.java:[line 1819] |
   |  |  Load of known null value in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.passesDeleteFamilyBloomFilter(byte[],
 int, int)  At AbstractMultiTenantReader.java:in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.passesDeleteFamilyBloomFilter(byte[],
 int, int)  At AbstractMultiTenantReader.java:[line 471] |
   |  |  Load of known null value in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.passesGeneralRowBloomFilter(byte[],
 int, int)  At AbstractMultiTenantReader.java:in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.passesGeneralRowBloomFilter(byte[],
 int, int)  At AbstractMultiTenantReader.java:[line 432] |
   |  |  Load of known null value in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.passesGeneralRowColBloomFilter(ExtendedCell)
  At AbstractMultiTenantReader.java:in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.passesGeneralRowColBloomFilter(ExtendedCell)
  At AbstractMultiTenantReader.java:[line 451] |
   |  |  Redundant nullcheck of lease which is known to be null in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.findSectionBloomState(boolean,
 boolean)  Redundant null check at AbstractMultiTenantReader.java:is known to 
be null in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.findSectionBloomState(boolean,
 boolean)  Redundant null check at AbstractMultiTenantReader.java:[line 571] |
   |  |  Redundant nullcheck of lease which is known to be null in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.getFirstKey()  
Redundant null check at AbstractMultiTenantReader.java:is known to be null in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.getFirstKey()  
Redundant null check at AbstractMultiTenantReader.java:[line 1657] |
   |  |  Redundant nullcheck of lease which is known to be null in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.getLastKey()  
Redundant null check at AbstractMultiTenantReader.java:is known to be null in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.getLastKey()  
Redundant null check at AbstractMultiTenantReader.java:[line 1694] |
   |  |  Redundant nullcheck of lease which is known to be null in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.loadDataBlockIndexFromSection(byte[])
  Redundant null check at AbstractMultiTenantReader.java:is known to be null in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.loadDataBlockIndexFromSection(byte[])
  Redundant null check at AbstractMultiTenantReader.java:[line 1800] |
   |  |  Redundant nullcheck of lease which is known to be null in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.loadMetaBlockFromSection(byte[],
 String, boolean)  Redundant null check at AbstractMultiTenantReader.java:is 
known to be null in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.loadMetaBlockFromSection(byte[],
 String, boolean)  Redundant null check at AbstractMultiTenantReader.java:[line 
1819] |
   |  |  Redundant nullcheck of lease which is known to be null in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.passesDeleteFamilyBloomFilter(byte[],
 int, int)  Redundant null check at AbstractMultiTenantReader.java:is known to 
be null in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.passesDeleteFamilyBloomFilter(byte[],
 int, int)  Redundant null check at AbstractMultiTenantReader.java:[line 471] |
   |  |  Redundant nullcheck of lease which is known to be null in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.passesGeneralRowBloomFilter(byte[],
 int, int)  Redundant null check at AbstractMultiTenantReader.java:is known to 
be null in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.passesGeneralRowBloomFilter(byte[],
 int, int)  Redundant null check at AbstractMultiTenantReader.java:[line 432] |
   |  |  Redundant nullcheck of lease which is known to be null in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.passesGeneralRowColBloomFilter(ExtendedCell)
  Redundant null check at AbstractMultiTenantReader.java:is known to be null in 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader.passesGeneralRowColBloomFilter(ExtendedCell)
  Redundant null check at AbstractMultiTenantReader.java:[line 451] |
   |  |  Should 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader$SectionReaderHolder 
be a _static_ inner class?  At AbstractMultiTenantReader.java:inner class?  At 
AbstractMultiTenantReader.java:[lines 1023-1083] |
   |  |  Should 
org.apache.hadoop.hbase.io.hfile.AbstractMultiTenantReader$SectionReaderLease 
be a _static_ inner class?  At AbstractMultiTenantReader.java:inner class?  At 
AbstractMultiTenantReader.java:[lines 1096-1129] |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.48 ServerAPI=1.48 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7296/21/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7296 |
   | JIRA Issue | HBASE-29588 |
   | Optional Tests | dupname asflicense javac codespell detsecrets xmllint 
spotless cc buflint bufcompat hbaseprotoc spotbugs checkstyle compile 
hadoopcheck hbaseanti |
   | uname | Linux 3e847745d00a 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 
19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | HBASE-29588-feature / 
a3ffdfbf39fbad99ee3b09c166eb24984f6ac2f0 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | Max. process+thread count | 71 (vs. ulimit of 30000) |
   | modules | C: hbase-protocol-shaded hbase-common hbase-server U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7296/21/console
 |
   | versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to