Copilot commented on code in PR #7352:
URL: https://github.com/apache/hbase/pull/7352#discussion_r2390784704
##########
hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseJupiterExtension.java:
##########
@@ -162,12 +162,17 @@ private <T> T runWithTimeout(Invocation<T> invocation,
ExtensionContext ctx) thr
} catch (ExecutionException e) {
throw ExceptionUtils.throwAsUncheckedException(e.getCause());
} catch (TimeoutException e) {
-
+ LOG.info(TimedOutTestsListener.buildThreadDiagnosticString());
throw new JUnitException(
"Test " + ctx.getDisplayName() + " timed out, deadline is " +
deadline, e);
}
}
+ private void printThreadDump() {
+ LOG.info("====> TEST TIMED OUT. PRINTING THREAD DUMP. <====");
+ LOG.info(TimedOutTestsListener.buildThreadDiagnosticString());
+ }
Review Comment:
The private method `printThreadDump()` is added but not used anywhere in the
code. This creates dead code that should either be removed or utilized where
the thread dump logging occurs on line 165.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
