EungsopYoo commented on code in PR #7291: URL: https://github.com/apache/hbase/pull/7291#discussion_r2434334938
########## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RowCacheKey.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.regionserver; + +import java.util.Arrays; +import java.util.Objects; +import org.apache.hadoop.hbase.io.HeapSize; +import org.apache.hadoop.hbase.util.Bytes; +import org.apache.hadoop.hbase.util.ClassSize; + [email protected] +public class RowCacheKey implements HeapSize { + public static final long FIXED_OVERHEAD = ClassSize.estimateBase(RowCacheKey.class, false); + + private final String encodedRegionName; + private final byte[] rowKey; + + // Row cache keys should not be evicted on close, since the cache may contain many entries and + // eviction would be slow. Instead, the region’s rowCacheSeqNum is used to generate new keys that + // ignore the existing cache when the region is reopened or bulk-loaded. Review Comment: https://github.com/apache/hbase/pull/7291/commits/6545e3196ea7259b9254dcee32d6db5322fae1e4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
