Apache9 commented on code in PR #7389:
URL: https://github.com/apache/hbase/pull/7389#discussion_r2437994050
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java:
##########
@@ -519,6 +520,7 @@ public Pair<Message, ExtendedCellScanner> call(RpcCall
call, MonitoredRPCHandler
// increment the number of requests that were exceptions.
metrics.exception(e);
+ if (e instanceof DoNotRetryRuntimeException) throw new
DoNotRetryIOException(e);
Review Comment:
The problem is a RuntimeException usually means there is a code bug, so we
may fail to clean up something in the call stack which causes problem, as we do
not expect there will be a RuntimeException...
This is what I actually concern about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
